Define addtag to copy the source register if MT is disabled - #98
Merged
Conversation
This allows more optimized codegen for when the target is known to implement MT. Fixes riscv#96
Florian Mayer (fmayer)
requested review from
Adam 'pi3' Zabrocki (Adam-pi3) and
deepak0414
May 13, 2026 00:47
Adam 'pi3' Zabrocki (Adam-pi3)
approved these changes
May 13, 2026
Luís Fiolhais (lfiolhais)
left a comment
Luís Fiolhais (lfiolhais)
left a comment
Contributor
There was a problem hiding this comment.
Two typos, and the removal of "we"
deepak0414
reviewed
May 13, 2026
deepak0414
reviewed
May 13, 2026
deepak0414
left a comment
deepak0414
left a comment
Collaborator
There was a problem hiding this comment.
Pending review comments from luis and I, lgtm
Co-authored-by: Luís Fiolhais <luisazenhas.fiolhais@protonmail.com> Signed-off-by: Florian Mayer <florian.mayer@bitsrc.org>
Co-authored-by: Luís Fiolhais <luisazenhas.fiolhais@protonmail.com> Signed-off-by: Florian Mayer <florian.mayer@bitsrc.org>
Co-authored-by: Luís Fiolhais <luisazenhas.fiolhais@protonmail.com> Signed-off-by: Florian Mayer <florian.mayer@bitsrc.org>
Signed-off-by: Florian Mayer <fmayer@google.com>
Radim Krčmář (radimkrcmar)
pushed a commit
to radimkrcmar/riscv-memory-tagging
that referenced
this pull request
Jun 26, 2026
* Define addtag to copy the source register if MT is disabled This allows more optimized codegen for when the target is known to implement MT. Fixes riscv#96 Signed-off-by: Florian Mayer <fmayer@google.com> Co-authored-by: Luís Fiolhais <luisazenhas.fiolhais@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows more optimized codegen for when the target is known to implement MT.
Fixes #96