Repository navigation
Keep the version stamp on the release tag when main refuses the push - #179
Merged
Merged
Conversation
The riscv organization ruleset requires signed commits and a passing DCO check on the default branch. version-bot.yml pushes its antora.yml stamp straight to main before tagging, and a bot's direct push satisfies neither, so the push is refused in every riscv repository. The bot then reset to main and tagged the unstamped commit: the tag's antora.yml named v0.0, scripts/build-pages-site.sh skipped it, and the release's versioned site path disappeared on the next push to main. Seen on riscv/riscv-memory-tagging v0.51. On refusal, keep the stamp commit and tag it, pushing only the tag. The ruleset targets branches, so the tag lands and carries a descriptor naming its own version. build-pdf.yml's stamp-site-version PR still brings the stamp onto main. Check for an existing tag before stamping, and accept one that is HEAD or the stamp commit on top of HEAD, so rerunning the bot for a version that is already tagged reuses the tag rather than failing on a fresh stamp commit. Update MIGRATION.md (Steps 12-14) to match, including merging the stamp PR with Squash and merge, since its bot commit is unsigned. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Bill Traynor <wmat@riscv.org>
Bill Traynor (wmat)
added a commit
that referenced
this pull request
Oct 19, 2026
Both sides added an entry at the top of CHANGELOG.md's [Unreleased] section: this branch's bot-signing entry and #179's version-stamp entry from main. Keep both. No other path conflicted; version-bot.yml auto-merged and carries both this branch's App-token step and #179's tag fallback. Signed-off-by: Bill Traynor <wmat@riscv.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The riscv organization ruleset requires signed commits and a passing DCO check on the default branch. version-bot.yml pushes its antora.yml stamp straight to main before tagging, and a bot's direct push satisfies neither, so the push is refused in every riscv repository. The bot then reset to main and tagged the unstamped commit: the tag's antora.yml named v0.0, scripts/build-pages-site.sh skipped it, and the release's versioned site path disappeared on the next push to main. Seen on riscv/riscv-memory-tagging v0.51.
On refusal, keep the stamp commit and tag it, pushing only the tag. The ruleset targets branches, so the tag lands and carries a descriptor naming its own version. build-pdf.yml's stamp-site-version PR still brings the stamp onto main.
Check for an existing tag before stamping, and accept one that is HEAD or the stamp commit on top of HEAD, so rerunning the bot for a version that is already tagged reuses the tag rather than failing on a fresh stamp commit.
Update MIGRATION.md (Steps 12-14) to match, including merging the stamp PR with Squash and merge, since its bot commit is unsigned.