Repository navigation
test(app): add learning evaluation seam typed coverage matrix - #95
Conversation
Work unit 3 child 6 (learning-promotion): typed authority failures never promote, skill misresolution guards, malformed explicit evidence, zero outcomes, unresolved-conflict escalation, and foreign-event isolation.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4e03b005e4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| it.each([ | ||
| ['authority-missing', undefined], | ||
| ['authority-malformed', { companyId: 'acme', subject, extra: 1 }], | ||
| ['authority-foreign', { companyId: 'other', subject, sourceRef: 'proof-1' }], |
There was a problem hiding this comment.
Expand the authority failure matrix before closing task 2.2
This matrix and the two cases below exercise only authority-missing, authority-malformed, authority-foreign, and authority-revoked, while design.md:48,66 requires coverage of every authority-unavailable reason. The app seam therefore remains untested for authority-stale, authority-ambiguous, authority-source-unresolvable, command/principal/policy mismatches, and authority-proof-unavailable, even though tasks.md now reports the typed matrix as complete; regressions that rewrite or fail to propagate any of those repository results would pass this suite.
Useful? React with 👍 / 👎.
Linked issue
Closes #89
PR type
type:bug)type:feature)type:docs)type:refactor)type:chore)type:breaking-change)Summary
pnpm checkexit 0 — 1576 passed | 6 skipped, 0 new warnings.Changes
packages/app/test/learning/evaluate-coverage.test.tsopenspec/changes/learning-promotion/tasks.mdVerification
pnpm exec vitest run packages/app/test/learning/evaluate-coverage.test.ts→ 9/9pnpm checkGREEN — 1576 passed | 6 skipped, 0 new warningsreview-8e7d436130116786(medium, reliability lens) approved with focused+full-gate evidence; pre-pr gateallowContributor checklist
status:approved.type:*label is applied.type/lowercase-description.