Feat/nixlbench with rocm#1
Open
riley-dixon wants to merge 2 commits into
Open
Conversation
riley-dixon
force-pushed
the
feat/nixlbench-with-rocm
branch
2 times, most recently
from
July 8, 2026 23:46
a1e8638 to
c8eb217
Compare
The base Dockerfile creates a minimal install of ROCm, along with a few other pre-requisites before the build image takes over. This may be replaced once a sufficiently new official ROCm docker image is available. Dockerfile.rocm is based on the existing build.sh script used by NIXL for building the NIXL environment. Instead of running in a script, the source dependency build & install steps are extracted into a multi-stage Docker build process to streamline the overall build. A build-rocm.sh is a copy of build.sh that is slightly modified to build NIXL with ROCm support that may be used by existing tools. Signed-off-by: Riley Dixon <riley.dixon@amd.com>
ROCm's host_defines.h defines an empty __noinline__ macro on GCC, which breaks toml++'s TOML_HAS_ATTR(__noinline__) check when hip/hip_runtime.h is included before toml++/toml.hpp. utils.h already includes toml++ first and then conditionally includes the GPU headers, so the early redundant includes in utils.cpp and nixl_worker.cpp are both the source of the breakage and unnecessary. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Stephen Bates <sbates@raithlin.com>
riley-dixon
force-pushed
the
feat/nixlbench-with-rocm
branch
from
July 10, 2026 16:08
c8eb217 to
44bba3c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Describe what this PR is doing.
Why?
Justification for the PR. If there is an existing issue/bug, please reference it. For
bug fixes, the 'Why?' and 'What?' can be merged into a single item.
How?
It is optional, but for complex PRs, please provide information about the design,
architecture, approach, etc.