Test docker images can now work on remote repos#16
Merged
Conversation
This will allow us to specify what version of ROCm we are trying to build hipFile against. This can be helpful in non-standard setups where ROCm is installed in a different location, as well as for downstream tasks reliant on the ROCm version (e.g. packaging). If ROCM_VERSION is not specified, a fallback method is provided to read the version file provided by ROCM_PATH.
These 3 environment variables are known/relied upon for setting the filename for the DEB/RPM packages. rocm-cmake does not consider if these are set as CMAKE variables. In CI we can easily set these environment variables as expected, but we would still like the ability for a developer to build this package locally and have a reasonably similar filename, without the developer needing to remember to explicitly provide these environment variables.
This is a rather widespread change across CI. The ROCm Version in each DOCKERFILE is now treated as a build argument instead of a constant. As such, the CI can specify on-demand which version of ROCm it would like to test against each distro. The changes made here also assume that the ROCm version will be part of the workflow matrix, and as such changes the container names to ensure no conflicts arise should the containers run on the same host. While ROCM_VERSION is passed around as an input/output in CI, it is also available directly from the CI image as an environment variable for convenience. One quirk: ROCm versions are typically expressed as MAJOR.MINOR.PATCH. The ROCm package repo (repo.radeon.com) however strips the PATCH if it is equal to 0. This shortened version is not used elsewhere outside of documentation/marketing.
This changes the GHCR URL that is used to pull the CI images. Originally it was fixed to the main hipFile repository. Now, the URL will set itself to the GHCR registry space of the repository the workflow is being operated on.
riley-dixon
force-pushed
the
rildixon/ci-set-rocm-version
branch
from
January 27, 2026 17:36
b825979 to
d886151
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.