Skip to content

fixed bug in param filtering #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ironcamel wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fixed bug in param filtering #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 3 additions & 11 deletions lib/Test/LWP/Recorder.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,22 +29,14 @@ sub new {
return $self;
}

sub _filter_param {
my ( $self, $key, $value ) = @_;
my %filter = map { $_ => 1 } @{ $self->{_test_options}->{filter_params} };
return join q{=}, $key, $filter{$key} ? q{} : $value;
}

sub _filter_all_params {
my $self = shift;
my $param_string = shift;
my %filter = map { $_ => 1 } @{ $self->{_test_options}{filter_params} };
## no critic (BuiltinFunctions::ProhibitStringySplit)
my %query = map { ( split q{=} )[ 0, 1 ] } split q{\&}, $param_string;
my %query = map { split q{=}, $_, 2 } split q{\&}, $param_string;
## use critic;
return %query
? reduce { $a . $self->_filter_param( $b, $query{$b} ) }
sort keys %query
: q{};
return join '&', map "$_=$query{$_}", sort grep !$filter{$_}, keys %query;
}

sub _get_cache_key {
Expand Down