feat: support dynamic attribute handler for component patches - #1
Merged
Conversation
Allow attr()/attrs() to accept a function that is invoked on each render with bound to the current component instance proxy, returning the value to apply. Falls back to static JSON arguments when a non-function value is passed.
- Rewrite fixit.test.mjs: remove internal spec/structure asserts, verify observable behavior (return values, this-binding, origin delegation, dynamic attr handler re-evaluation, fail-closed on throw/clear) - Expand patch.js demo: add setInterval+clearInterval, multi-level console, dynamic attr handler (fontColor/fontSize as functions), reorganize by capability with comments
…on, attr handler - Extract shared test runtime mock into _runtime.mjs (reused by fixit + perf tests) - 4 perf scenarios with 20% degradation gate: property access, method call, origin delegation, attr handler resolution - All scenarios run ~8-11% degradation, well within the 20% threshold
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow attr()/attrs() to accept a function that is invoked on each render with bound to the current component instance proxy, returning the value to apply. Falls back to static JSON arguments when a non-function value is passed.