Reproduction case of exception thrown when disabling check thats also in XepPatchChecks#2
Open
oxkitsune wants to merge 1 commit into
Open
Reproduction case of exception thrown when disabling check thats also in XepPatchChecks#2oxkitsune wants to merge 1 commit into
XepPatchChecks#2oxkitsune wants to merge 1 commit into
Conversation
Owner
|
As discussed offline; related Error Prone issue: google/error-prone#3908. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When disabling a check using
-Xep:XXX:OFFwhile the check is listed in-XepPatchChecksresults in aNoSuchElementExceptionbeing thrown when EP tries to get the severity level of the check.This PR introduces code that triggers the
StaticImportcheck to get a reproducible case.The issue can be reproduced using the following
mvninvocation:mvn clean install \ -Perror-prone \ -Derror-prone.patch-args="-XepPatchLocation:IN_PLACE -XepPatchChecks:StaticImport -Xep:StaticImport:OFF"And results in the following exception: