feat: Support setting the audience (aud)#25
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for a customizable signing audience (aud) required by some Apple APIs.
- Introduces an Audience field in both Token and StoreConfig structures.
- Updates token generation to use the provided audience value or default to "appstoreconnect-v1" when unset.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| token.go | Added Audience field, updated WithConfig and Generate methods to set and use the audience value. |
| store.go | Added Audience field in the StoreConfig structure. |
Comments suppressed due to low confidence (1)
token.go:95
- Ensure that unit tests cover the scenario where Audience is not provided, verifying that the default value "appstoreconnect-v1" is correctly applied.
audience = "appstoreconnect-v1"
| } | ||
| audience := t.Audience | ||
| if audience == "" { | ||
| audience = "appstoreconnect-v1" |
There was a problem hiding this comment.
Consider extracting the default audience value "appstoreconnect-v1" into a constant to improve maintainability and avoid magic strings.
Suggested change
| audience = "appstoreconnect-v1" | |
| audience = DefaultAudience |
richzw
requested changes
Jun 21, 2025
Contributor
Author
|
Done~ |
Owner
|
LGTM, Thank you for your PR |
richzw
approved these changes
Jun 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support allowing users to set the signing audience, as some Apple APIs require a specific audience.