[3.0] Minify CSS and JS, update dependencies & documentation, fix issues from PR 22 - #26
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to PR #22 .
This pull request (PR) for the upcoming new major version 3 adds the minification of CSS and JS to the build process and updates the demo and the documentation for that.
In addition, it fixes following issues which were introduced with PR #22 :
facebooklikebutton because the corresponding code was moved inside a loop, and thevalueandfbValuevariables were mixed up.See commit 0a94767 for the fix.
facebooklikeandfacebookwere provided via thedata-servicesattribute in exactly the mentioned order, thefacebookbutton was shown before thefacebooklikebutton, i.e. for these 2 buttons the ordering from thedata-servicesattribute was not respected.See commit a118588 for the fix.
facebooklikedialog did not get the right link to the stylesheet.See commit c96c0cc for the fix.
Finally all dependencies are updated (except of a major update of fontawesome which might be done later).