Skip to content

[3.0] Minify CSS and JS, update dependencies & documentation, fix issues from PR 22 - #26

Merged
richard67 merged 13 commits into
3.0-devfrom
3.0-dev-minify-css-and-npm-update
Dec 30, 2025
Merged

[3.0] Minify CSS and JS, update dependencies & documentation, fix issues from PR 22#26
richard67 merged 13 commits into
3.0-devfrom
3.0-dev-minify-css-and-npm-update

Conversation

@richard67

@richard67 richard67 commented Dec 29, 2025

Copy link
Copy Markdown
Owner

Follow up to PR #22 .

This pull request (PR) for the upcoming new major version 3 adds the minification of CSS and JS to the build process and updates the demo and the documentation for that.

In addition, it fixes following issues which were introduced with PR #22 :

  • Multiple share counters were appended to the facebooklike button because the corresponding code was moved inside a loop, and the value and fbValue variables were mixed up.
    See commit 0a94767 for the fix.
  • When both services facebooklike and facebook were provided via the data-services attribute in exactly the mentioned order, the facebook button was shown before the facebooklike button, i.e. for these 2 buttons the ordering from the data-services attribute was not respected.
    See commit a118588 for the fix.
  • The query selector to get the script src was not adapted to the change script name. Therefore the facebooklike dialog did not get the right link to the stylesheet.
    See commit c96c0cc for the fix.

Finally all dependencies are updated (except of a major update of fontawesome which might be done later).

@richard67 richard67 changed the title [3.0] [WiP] Minify CSS and JS, update dependencies & documentation, fix issues from PR 22 [3.0] Minify CSS and JS, update dependencies & documentation, fix issues from PR 22 Dec 30, 2025
@richard67
richard67 merged commit cfc43ca into 3.0-dev Dec 30, 2025
@richard67
richard67 deleted the 3.0-dev-minify-css-and-npm-update branch December 30, 2025 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant