Skip to content

feature: Stage 4 merge tools use /tmp view of Portage marker (issue #68) - #71

Merged
rich0 merged 1 commit into
developfrom
feature/stage4-merge-view-temps
Jul 18, 2026
Merged

feature: Stage 4 merge tools use /tmp view of Portage marker (issue #68)#71
rich0 merged 1 commit into
developfrom
feature/stage4-merge-view-temps

Conversation

@rich0

@rich0 rich0 commented Jul 18, 2026

Copy link
Copy Markdown
Owner

Summary

Implements #68: Stage 4 interactive 2-way merges pass tools a disposable $TMPDIR copy of the Portage marker ($path_new), reusing the Stage 3 helpers from #65 / PR #67.

  • update_stage4 calls launch_tool_with_merge_view_temps (marker view; ancestor is a no-op when missing)
  • Live file and *.merge remain real; replace/keep/merge/cancel still use real paths after tool exit
  • tool_intro notes the new-file pane is a temporary view for 2-way-relevant tools
  • Tier D: path asserts + hostile cancel/complete for Stage 4 (sdiff / imediff / kdiff3 mocks)
  • docs/ARCHITECTURE.md Stage 4 documented

Acceptance criteria

  • Stage 4 tools receive /tmp (or $TMPDIR) copy of $path_new
  • Real marker intact if tool overwrites input and user cancels
  • Successful replace/merge/keep still operate on real paths after tool exit
  • Live file is never temp-copied
  • File-focused tests (hostile mock + path asserts)
  • tool_intro notes temporary new pane when applicable

Test plan

  • perl -c cfg-update
  • ./test/run-tests.sh --full (252 passed, 0 failed)

Reuse launch_tool_with_merge_view_temps so interactive 2-way tools
receive a disposable $TMPDIR copy of $path_new, not the real ._cfg*
marker. Live and *.merge paths stay real. Extend tool_intro, docs,
and Tier D path/hostile coverage.
@rich0
rich0 merged commit 94291de into develop Jul 18, 2026
1 check passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in Refactor/cleanup cfg-update Jul 18, 2026
@rich0
rich0 deleted the feature/stage4-merge-view-temps branch August 1, 2026 14:09
@rich0
rich0 restored the feature/stage4-merge-view-temps branch August 1, 2026 14:09
@rich0
rich0 deleted the feature/stage4-merge-view-temps branch August 1, 2026 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant