feature: validate markers against Portage CONTENTS before ancestor promote (issue #66) - #69
Merged
Merged
Conversation
…stor promote (issue #66) Before promoting a staged marker snapshot to ._new-cfg_*, compare its MD5 to the Portage VDB CONTENTS digest for the live path (last-install BUILD_TIME). Mismatch skips ancestor promotion with a warning; missing VDB fails open. New helpers take all inputs via parameters/returns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
._cfg*snapshot to._new-cfg_*(Stage 2 ancestor), compare its MD5 to Portage VDBCONTENTSfor the live path, using the most recently installed package (BUILD_TIME, else CONTENTS mtime).lookup_contents_md5_for_liveandpromote_backup_newtake all inputs via parameters/returns (no new global coupling).update_merge_complete,update_replace_complete, andupdate_keep_complete.Closes #66
Test plan
perl -c cfg-update./test/run-tests.sh --full(227 passed)