Skip to content

cleanup: remove gtkdiff from supported merge tools - #59

Merged
rich0 merged 1 commit into
developfrom
cleanup/remove-gtkdiff
Jun 20, 2026
Merged

cleanup: remove gtkdiff from supported merge tools#59
rich0 merged 1 commit into
developfrom
cleanup/remove-gtkdiff

Conversation

@rich0

@rich0 rich0 commented Jun 20, 2026

Copy link
Copy Markdown
Owner

Fixes #55

Summary

Removes gtkdiff from supported merge tools. Investigation (see issue comment) confirmed it is no longer packaged on Gentoo, depends on obsolete GNOME libraries, and was only half-integrated in cfg-update (launch_tool had a command branch but check_tool omitted it from the 2-way regex, disabling stage 4).

Users who build gtkdiff themselves can still set MERGE_TOOL to it; the tool falls through to the generic unsupported-tool command path.

Changes

  • Remove gtkdiff from launched_tool_needs_gui, tool_saves_mergefile_when_aborted, launch_tool, tool_intro, and --help
  • Remove gtkdiff row from cfg-update.conf supported-tools table
  • Remove gtkdiff from INVENTORY.md and ebuild pkg_postinst hints

Note

Independent of PR #58 (imediff cleanup). Both touch ebuild/cfg-update.conf — merge order may require a trivial conflict resolution.

Testing

perl -c cfg-update
./test/run-tests.sh --full

180 passed, 0 failed.

gtkdiff is no longer packaged on Gentoo and was only half-integrated
(launch_tool support without stage 4 detection). Remove from code paths,
config template, ebuild hints, and inventory.

Fixes #55
@rich0
rich0 force-pushed the cleanup/remove-gtkdiff branch from fe58694 to aa43c03 Compare June 20, 2026 14:15
@rich0
rich0 merged commit 43a2355 into develop Jun 20, 2026
1 check passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in Refactor/cleanup cfg-update Jun 20, 2026
rich0 added a commit that referenced this pull request Jun 20, 2026
Resolve conflicts with gtkdiff removal (PR #59): keep imediff-only
support and no gtkdiff in tool_saves_mergefile_when_aborted or --help.
@rich0
rich0 deleted the cleanup/remove-gtkdiff branch August 1, 2026 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant