Skip to content

Rhai shared scoped refs#901

Open
mrazorvin wants to merge 6 commits into
rhaiscript:mainfrom
mrazorvin:rhai-shared-scoped-refs
Open

Rhai shared scoped refs#901
mrazorvin wants to merge 6 commits into
rhaiscript:mainfrom
mrazorvin:rhai-shared-scoped-refs

Conversation

@mrazorvin

Copy link
Copy Markdown

No description provided.

@schungx

schungx commented Jul 17, 2024

Copy link
Copy Markdown
Collaborator

A couple of quick observations:

  • Try not to change existing API like register_get or else we'll break code. Better to add to the API surface instead.

  • Same for examples and tests... Try to add instead of change. This would be quite messy to undo by the time we're ready to merge.

  • Try to have as few changed files as possible as that would help with reasoning. Also it'll help putting this under a feature flag.

@schungx

schungx commented Sep 30, 2024

Copy link
Copy Markdown
Collaborator

I wonder how this is working out...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants