ncl: keymap-codegen: provide json_deserializable_keymap - #391
Merged
Conversation
rgoulter
force-pushed
the
tests-cucumber-deserializable-json
branch
from
September 7, 2025 08:55
d8d3bd2 to
d5290cd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#381 rewrites the implementation, such that "keymap.json" is no longer the deserialized value.
I think the right way to do it is to keep keymap.json as an intermediate representation, and use keymap-codegen to take the "keymap.json" value, and transform it to how the Rust code expects it (either as a deserializable json value, or by constructing rust expressions which get compiled by build.rs).
So, this PR introduces a new field for keymap-codegen, and updates the smart keymap nickel helper to use that.