Add start point of route to the created track

[jrheinlaender]

The start point of the calculated weather route was not included in the created track.

[quinton-hoole]

Thanks @jrheinlaender !

Rather than cut 'n paste all that duplicate code, could we not rather wrap it all up in a method, and call that method for the start point, as well as all other points? I think that would be tidier and avoid future bugs (where for example the piece of duplicated code is updated with in one , but not another.

[quinton-hoole]

Thanks @jrheinlaender ! That looks much better.

You'll probably want to replace this:

add_waypoint_to_track(
      newPath, routemapoverlay.GetConfiguration().StartLat,
      heading_resolve(routemapoverlay.GetConfiguration().StartLon),
      routemapoverlay.GetConfiguration().StartTime);

With something like this, to avoid all the duplicate method calls, and make the code more readable.

auto cfg = routemapoverlay.GetConfiguration();
add_waypoint_to_track(
      newPath, cfg.StartLat, heading_resolve(cfg.StartLon), cfg.StartTime);

[quinton-hoole]

Thanks for that. Code looks great now. And thanks for putting up with my nit picking 😁

[quinton-hoole]

@rgleason will have to merge this. My permissions were revoked, for some reason.

[jrheinlaender]

Thanks for that. Code looks great now. And thanks for putting up with my nit picking 😁

That's fine. Productive criticism is always welcome.