[rghamilton3]

Summary

Fixes that were applied after PR #4 was accidentally merged. These commits address:

1. Tokio runtime panic - Move host.start() to Tauri's setup hook with async_runtime::spawn
2. Code review feedback - All issues from PR review:
   • RwLock poison handling in get_providers_status
   • Sensor ID collision fix in LinuxProvider (include device name)
   • min_poll_interval_ms clamping implementation
   • thiserror derive usage for ProviderError
   • Shared test providers extracted to common module
   • provider_id → device_id rename for accuracy

Test Plan

• All workspace tests pass
• cargo check --workspace clean
• cargo clippy clean
• bun run tauri dev starts without panic

[github-actions]

PR Review Summary

The PR addresses several post-merge issues, but I found a few remaining problems:

🔴 Bugs

1. Multiple temperature sensors from same device will collide (linux.rs:266-276)

The sensor ID doesn't include the temp index, so temp1_input, temp2_input, etc. from the same hwmon device all produce the same ID like cpu.coretemp.temperature:

let index: String = name  // index is extracted but never used!
  .chars()
  .skip(4)
  .take_while(|c| c.is_ascii_digit())
  .collect();

// Sensor ID omits index
let sensor_id = format!("cpu.{}.temperature", device_name);

Fix: Include the index in the sensor ID:

format!("cpu.{}.temp{}.temperature", device_name, index)

2. Sensor ID format mismatch between discovery and poll (linux.rs:519)

In find_temp_sensors, non-CPU/GPU devices produce {device_name}.temperature:

format!("{}.temperature", device_name.replace(' ', "_"))

But in poll_temperatures, they produce {device_name}.{device_name}.temperature:

let sensor_id_str = format!("{}.{}.temperature", sensor_prefix, device_name);

These won't match, causing samples to fail to push.

🟡 Code Quality

3. Duplicate test providers (host.rs:402-551)

The inline PanickingProvider, PollPanickingProvider, and HealthyProvider duplicate the shared test module in tests/common/mod.rs. The inline versions should be removed and tests should use the shared module.

4. Potential panic in async context (lib.rs:89)

host_clone.write().unwrap().start();

If the lock is poisoned, this panics in the async runtime. Consider:

if let Ok(mut host) = host_clone.write() {
  host.start();
} else {
  tracing::error!("Provider host lock poisoned");
}

✅ Good Changes

• thiserror derive usage is clean
• RwLock poison handling in get_providers_status is correct
• min_poll_interval_ms clamping is properly implemented
• Git identity configuration in workflow fixes the CI issue

opencode session  |  github run