Repository navigation
refactor(workout): split log route into EventWorkoutView and StrengthWorkoutView - #115
Merged
Merged
Conversation
…WorkoutView Extract two rendering paths from the 914-line log.$workoutId.tsx into dedicated components. Route file slimmed from 914 to 562 lines; all state, hooks, and handlers remain in the route orchestrator. New files: - src/components/workout/event-workout-view.tsx (113 lines) - src/components/workout/strength-workout-view.tsx (489 lines)
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
FIX (Critical) - P22-001: computeElapsed catch now calls setPageError on corrupt timer data - P22-002: circuit onExerciseDone guard logs + setPageError instead of silent return FIX (High) - P22-003: workoutLog null guard returns surface div + error log instead of blank null - P22-004: handleMarkDone/handleExpandDone guard empty activityId with log + setPageError - P22-005: confirmSet prop adds exerciseName? 4th parameter to StrengthWorkoutViewProps FIX (Medium) - P22-006: circuit catch prefix [workout-log] -> [strength-workout-view] - P22-007: CardioPanel/RuckPanel catch prefix [workout-page] -> [strength-workout-view] - P22-008: handleDiscard awaits navigate with .catch error + setPageError - P22-013: handleSummaryDone navigate chains .catch with log + setPageError FIX (Low) - P22-009: remove exerciseNames prop from StrengthWorkoutView; derive from exerciseMap - P22-010: export UndoAction from active-workout-store; use in StrengthWorkoutViewProps - P22-011: extract ProgramBannerProps named type with weekNumber: number required - P22-012: export EventWorkoutLog type from event-workout-view TASK: P22-014 added to Ideas backlog (move modal state into StrengthWorkoutView) ADR: P22-015 -> ADR-022 (mutation orchestration boundary in StrengthWorkoutView) Review: Context/Reviews/0022-pr115-split-log-workout-route-2026-04-20.md
This was referenced Apr 23, 2026
rghamilton3
added a commit
that referenced
this pull request
Apr 23, 2026
Fix no-explicit-any lint violations in event-workout-view and strength-workout-view test files introduced by the #115 refactor.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EventWorkoutViewcomponent (113 lines)StrengthWorkoutViewcomponent (489 lines)Test plan
bun run buildpasses (TypeScript clean)bun run testpasses (2476 tests)