Repository navigation
test(program-builder): session-detail-utils coverage - #110
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
rghamilton3
added a commit
that referenced
this pull request
Apr 15, 2026
Covers 4 gaps identified in PR #110 review (P16-001 through P16-004): - formatLoad: emom and descendingReps without-load paths (P16-001) - buildGroupedActivities: orphan activity drop-silently contract (P16-002) - formatSetsReps: mixed number/range fixedSets combinations (P16-003) - formatSetsReps + formatLoad: unrecognized scheme type fallthrough (P16-004) Test count: 57 → 64 Review: Context/Reviews/0016-pr110-session-detail-utils-tests-2026-04-15.md
rghamilton3
added a commit
that referenced
this pull request
Apr 15, 2026
All 4 [TASK] findings implemented directly in test file. Status: Resolved
57 tests across formatSetsReps, formatLoad, formatLoadSpec, formatSeconds, and buildGroupedActivities -- all previously unreached per static analysis. Includes quick-plan artifact documenting scope decisions and deferred items (E2E display broadcast round-trip, useSessionTemplatesFull hook).
Covers 4 gaps identified in PR #110 review (P16-001 through P16-004): - formatLoad: emom and descendingReps without-load paths (P16-001) - buildGroupedActivities: orphan activity drop-silently contract (P16-002) - formatSetsReps: mixed number/range fixedSets combinations (P16-003) - formatSetsReps + formatLoad: unrecognized scheme type fallthrough (P16-004) Test count: 57 → 64 Review: Context/Reviews/0016-pr110-session-detail-utils-tests-2026-04-15.md
All 4 [TASK] findings implemented directly in test file. Status: Resolved
rghamilton3
force-pushed
the
worktree-chore+tests
branch
from
April 15, 2026 14:30
882cfff to
f1c0f6b
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/components/program-builder/session-detail-utils.ts-- all 5 exported pure functions previously had zero test coverage per static analysisFunctions covered
formatSecondsformatLoadSpecformatSetsRepsformatLoadbuildGroupedActivitiesDeferred (documented in quick plan)
useSessionTemplatesFull-- hook requiring renderHook + adapter mocking, tracked in quick planContext/Backlog/e2e-display-broadcast-roundtrip.mdTest plan
bun run test-- 2525/2525 passbun run build-- clean (no TS errors)