refactor(adapters): eliminate data-mapper layer

Context/Backlog/Ideas.md

@@ -5,6 +5,19 @@ skill. Prioritize via the backlog-prioritize skill.
 
 <!-- Add new ideas below this line -->
 
+## P17 Review: Adapter test coverage gaps (PR #107)
+
+**Added:** 2026-04-12
+**Source:** `Context/Reviews/0017-pr107-camelcase-conv-2026-04-12.md`
+**Priority:** Medium
+
+| #       | File                                          | Improvement                                                                                                                                     | Status |
+| ------- | --------------------------------------------- | ----------------------------------------------------------------------------------------------------------------------------------------------- | ------ |
+| P17-007 | `src/lib/__tests__/adapter-utils.test.ts`     | New file: unit tests for `camelizeKeys` and `parseJsonOrValue` -- already-camelCase passthrough, digit-adjacent keys, multiple/leading underscores, object passthrough, error on malformed JSON | Open   |
+| P17-008 | `src/lib/__tests__/supabase-adapter.test.ts`  | Add `mapScheduledSession` malformed-JSON fallback test: fixture with bad JSON in `overrides`, assert `result.overrides === undefined` and `console.warn` called | Open   |
+| P17-009 | `src/lib/__tests__/supabase-adapter.test.ts`  | Fix JSONB fixtures in `sessionTemplateRow` and `templateActivityRow` to pass pre-parsed objects (not `JSON.stringify`) to exercise the object-passthrough branch of `parseJsonOrValue` | Open   |
+| P17-010 | `src/lib/__tests__/supabase-adapter.test.ts`  | Add `supports1RM` assertion to `getExercises` happy-path test (line 301); add fixture value and assert it round-trips correctly | Open   |
+
 ## ~~Chat Data Layer Refinements (PR #33 review suggestions)~~ (Resolved 2026-04-05)
 
 **Added:** 2026-04-02
@@ -64,6 +77,21 @@ The `OneRmManagement` component was removed from the profile page during the res
 **Added:** 2026-04-05
 **Resolution:** Reordered sidebar nav into logical groups: core tools, reference, social. Commit `1b359d2`.
 
+### Exercise completion signal during active workout
+
+**Added:** 2026-04-12
+**Source:** User feedback
+**Priority:** Medium
+
+Two related UX gaps in the workout logger:
+
+1. **"Done with this exercise" affordance** -- No explicit way to mark an exercise block as finished mid-workout. Users who finish squats before the planned sets are complete (injury, RPE ceiling, time) have no way to signal they're moving on. Options: a "Mark complete" button per exercise block, a long-press gesture, or a swipe action that collapses the block and flags it as done.
+
+2. **Trailing auto-populated set ambiguity** -- When the logger auto-populates a new set row, it's unclear whether exiting the exercise (or ending the workout) will count that empty row as a logged set or discard it. Users are left guessing whether their volume is being over-counted. Need either: discard empty trailing sets on exit, or show explicit "incomplete set" vs "complete set" state that is visible before saving.
+
+**Related:** `src/routes/_authenticated/log.$workoutId.tsx`, workout logger state, set auto-population logic
+**Area:** Workout logger UX
+
 ### Split log.$workoutId route into three components
 **Added:** 2026-04-06
 **Context:** `src/routes/_authenticated/log.$workoutId.tsx` is ~800 lines with three distinct rendering paths (event workout, strength workout, post-workout summary) toggled by conditional branches. Splitting into separate route components would clarify ownership, shrink the file, and isolate state hoisting per path.

Context/QuickPlans/2026-04-12-remove-data-mapper.md

@@ -0,0 +1,118 @@
+# Quick Plan: Remove DataMapper Layer
+
+**Task:** Eliminate `data-mapper.ts` (1,097 LOC) by enabling Supabase JS built-in camelCase transformation and inlining non-trivial mappings into the adapters directly.
+
+**Branch:** `chore/camelcase-conv` (already in progress)
+
+---
+
+## Goal
+
+Reduce adapter infrastructure surface area by ~1,100+ LOC. New domain entities should touch at most 2 files (adapter + domain type), not 4+. The `to*` read-path mappers that do mechanical snake_case -> camelCase renaming become redundant once the client handles it.
+
+---
+
+## Approach
+
+### Step 1 -- Verify Supabase JS camelCase API
+
+Before touching code, confirm the exact client option. The Supabase JS v2 client passes through to `@supabase/postgrest-js`. Look for:
+
+```ts
+// Option A: db-level transform (postgrest-js >= 1.16 / supabase-js >= 2.x)
+createClient(url, key, {
+  db: { schema: 'public' },
+  global: {
+    fetch: /* ... */,
+  },
+})
+```
+
+Check `bun.lockb` / `package.json` for `@supabase/supabase-js` version, then verify against its changelog or source whether `transform: { camelize: true }` or a `fetchOptions` flag exists.
+
+**If the flag does not exist in the installed version:** either upgrade `@supabase/supabase-js` to the version that ships it, or evaluate `postgrest-js`'s `camelize` option directly. Do not proceed until this is confirmed -- the entire approach depends on it.
+
+### Step 2 -- Audit mapper functions (classify before deleting)
+
+Read `data-mapper.ts` and tag each function as one of:
+
+| Class | Description | Action |
+|---|---|---|
+| **A -- Pure rename** | Only snake_case -> camelCase field renames, no logic | Delete after enabling client transform |
+| **B -- Non-trivial read** | JSON parsing, type coercion, computed fields, nested mapping | Inline into `supabase-adapter.ts` at the call site |
+| **C -- Write path** | `from*` mappers: camelCase domain -> snake_case DB row | Keep, inline into adapter (client camelCase flag does not affect writes) |
+| **D -- Shared utility** | `parseJsonOrValue`, helpers used by multiple mappers | Inline or move to a small `adapter-utils.ts` |
+
+The preview shows 54 functions: `parseJsonOrValue`, `toExercise`, `fromExercise`, `toWorkoutLog`, `fromWorkoutLog`, `toLoggedActivityGroup`, and ~49 more. Expect ~60% to be Class A (eliminate), ~20% Class B (inline), ~20% Class C (write-path, inline).
+
+### Step 3 -- Enable camelCase on Supabase client
+
+Locate `createClient` call (likely `src/lib/supabase.ts` or similar). Add the camelCase flag once confirmed from Step 1.
+
+Update `ExerciseRow`, `WorkoutLogRow`, etc. row types if they will now be returned camelCased by the client -- or remove them entirely if the domain types are used directly after this change.
+
+### Step 4 -- Delete Class A mappers; inline B and C
+
+For each Class A `to*` function:
+- Find all call sites in `supabase-adapter.ts` via search
+- Remove the mapper call (client now returns camelCase directly)
+- Remove the function from `data-mapper.ts`
+
+For each Class B `to*` function:
+- Move the non-trivial logic inline to the adapter call site or a private helper in the adapter file
+- Remove from `data-mapper.ts`
+
+For each Class C `from*` function:
+- Move inline to the adapter write method (insert/upsert)
+- Remove from `data-mapper.ts`
+
+### Step 5 -- Handle TauriAdapter
+
+`src/lib/tauri-adapter.ts` (2,717 LOC) also uses mapper functions but calls SQLite via Tauri commands, not the Supabase JS client. The camelCase flag does not help here. Two options:
+
+- **Option A (preferred):** Inline all tauri-side mappings directly into the adapter. Same classification (A/B/C) applies but all classes must be inlined (no client magic).
+- **Option B (deferred):** Leave Tauri mappings in a reduced `tauri-mapper.ts` if the volume is large enough to warrant it. Acceptable as a follow-up.
+
+Decide per volume -- if tauri adapter uses >20 mapper functions, Option B is reasonable.
+
+### Step 6 -- Check sharing mappers
+
+The description mentions `sharing-mappers.ts` and `share-rpc-mapper.ts`. Search confirms these do not currently exist on this branch. If added in future, apply the same classification at the time of creation -- do not reintroduce a separate mapper layer.
+
+### Step 7 -- Delete `data-mapper.ts`
+
+Once all functions are migrated, confirm `data-mapper.ts` has zero imports via:
+```bash
+bun run build
+```
+
+Then delete it. Run tests.
+
+---
+
+## Verification
+
+- [ ] `bun run build` passes with no TS errors
+- [ ] `bun run test` passes
+- [ ] `src/lib/data-mapper.ts` no longer exists
+- [ ] No import of `data-mapper` anywhere in codebase
+- [ ] New entity checklist: touches adapter file + domain type only (not 4+ files)
+- [ ] Supabase read paths return camelCased fields confirmed via manual smoke test
+
+---
+
+## Risks
+
+| Risk | Mitigation |
+|---|---|
+| Supabase camelCase flag does not exist in installed version | Verify version before starting; upgrade if needed |
+| JSONB columns return nested snake_case (flag may not recurse into JSON) | Audit JSON fields in Class B -- keep explicit deep-transform helpers for those |
+| Write-path (`from*` mappers) breaks if Supabase client also camelize-transforms inputs | Test inserts after enabling flag; writes likely unaffected (flag is read-side) |
+| TauriAdapter volume makes inline approach unwieldy | Accept a smaller `tauri-mapper.ts` (Option B) if >20 functions -- explicit decision, not default |
+| Row type definitions become orphaned or misaligned | Remove or rename `*Row` types to match new camelCase client output; validate with `tsc` |
+
+---
+
+## Execution
+
+`/impl` -- straightforward single-adapter refactor with clear classification steps.