ci: optimize wasm build#8
Merged
Merged
Conversation
alvgaona
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The release wasm grew to ~125 MiB in v0.5.0 (Rerun 0.34), over
wrangler r2 object put's single-request limit. That failed thedeploy-wasmjob and leftapp.rewire.runwith the newrewire_viewer.jspaired with the stale v0.4.0 wasm (a wasm-bindgen ABI mismatch = broken viewer). This addswasm-opt -Ozto thebuild-wasmjob so the deployed wasm is shrunk before upload.Changes
release.yamlbuild-wasm: installbinaryen, runwasm-opt -Ozon the wasm-bindgen output before packaging/upload.Verified locally on the v0.5.0 wasm: 125 MiB to 87 MiB (31% smaller), export ABI preserved (84 exports incl.
memory/__wbindgen_malloc/__wbindgen_free), so it stays compatible withrewire_viewer.js. Also faster for users. The R2 object stays uncompressed so Cloudflare's edge keeps brotli-compressing it.Related
deploy-wasmfailure.Checklist
wasm-opt -Ozresult validated locally (size + ABI). The step runs on the next tag.Breaking changes
None.