Skip to content

fix(wait): don't print job status in wait builtin#1174

Open
reubeno wants to merge 1 commit into
mainfrom
wait-output
Open

fix(wait): don't print job status in wait builtin#1174
reubeno wants to merge 1 commit into
mainfrom
wait-output

Conversation

@reubeno

@reubeno reubeno commented May 31, 2026

Copy link
Copy Markdown
Owner

The wait builtin printed each completed job to stdout when job control was enabled. bash's wait is silent on both stdout and stderr; job-completion notices ("[1]+ Done ...") belong to the interactive prompt cycle, not to wait.

@github-actions

github-actions Bot commented May 31, 2026

Copy link
Copy Markdown

Test Results

    5 files     40 suites   14m 35s ⏱️
2 507 tests 2 505 ✅ 0 💤 2 ❌
7 797 runs  7 795 ✅ 0 💤 2 ❌

For more details on these failures, see this check.

Results for commit 55cf932.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented May 31, 2026

Copy link
Copy Markdown

Performance Benchmark Report

Benchmark name Baseline (μs) Test/PR (μs) Delta (μs) Delta %
clone_shell_object 19.53 μs 17.25 μs -2.29 μs 🟢 -11.70%
eval_arithmetic 0.15 μs 0.15 μs -0.00 μs ⚪ Unchanged
expand_one_string 1.60 μs 1.60 μs 0.01 μs ⚪ Unchanged
for_loop 31.50 μs 31.30 μs -0.20 μs ⚪ Unchanged
full_peg_complex 57.66 μs 57.58 μs -0.08 μs ⚪ Unchanged
full_peg_for_loop 6.29 μs 6.28 μs -0.02 μs ⚪ Unchanged
full_peg_nested_expansions 16.00 μs 15.96 μs -0.04 μs ⚪ Unchanged
full_peg_pipeline 4.17 μs 4.25 μs 0.08 μs 🟠 +1.85%
full_peg_simple 1.75 μs 1.81 μs 0.06 μs 🟠 +3.25%
function_call 3.23 μs 3.25 μs 0.01 μs ⚪ Unchanged
instantiate_shell 53.79 μs 53.90 μs 0.11 μs ⚪ Unchanged
instantiate_shell_with_init_scripts 25550.30 μs 25647.11 μs 96.81 μs ⚪ Unchanged
parse_peg_bash_completion 2084.20 μs 2086.43 μs 2.24 μs ⚪ Unchanged
parse_peg_complex 20.33 μs 20.38 μs 0.06 μs ⚪ Unchanged
parse_peg_for_loop 1.99 μs 2.06 μs 0.07 μs 🟠 +3.58%
parse_peg_pipeline 2.12 μs 2.19 μs 0.07 μs 🟠 +3.45%
parse_peg_simple 1.08 μs 1.11 μs 0.02 μs ⚪ Unchanged
run_echo_builtin_command 15.98 μs 15.71 μs -0.27 μs ⚪ Unchanged
tokenize_sample_script 3.38 μs 3.37 μs -0.01 μs ⚪ Unchanged

Code Coverage Report: Only Changed Files listed

Package Base Coverage New Coverage Difference
brush-builtins/src/set.rs 🟢 79.3% 🟢 80.18% 🟢 0.88%
brush-builtins/src/wait.rs 🟠 67.74% 🟠 70.37% 🟢 2.63%
brush-interactive/src/highlighting.rs 🟠 72.92% 🟢 89.94% 🟢 17.02%
brush-interactive/src/reedline/highlighter.rs 🔴 13.19% 🔴 13.33% 🟢 0.14%
Overall Coverage 🟢 74.49% 🟢 74.75% 🟢 0.26%

Minimum allowed coverage is 70%, this run produced 74.75%
Maximum allowed coverage difference is -5%, this run produced 0.26%

Test Summary: bash-completion test suite

Outcome Count Percentage
✅ Pass 1582 75.01
❗️ Error 17 0.81
❌ Fail 156 7.40
⏩ Skip 339 16.07
❎ Expected Fail 13 0.62
✔️ Unexpected Pass 2 0.09
📊 Total 2109 100.00

The `wait` builtin printed each completed job to stdout when job control was
enabled. bash's `wait` is silent on both stdout and stderr; job-completion
notices ("[1]+ Done ...") belong to the interactive prompt cycle, not to
`wait`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant