fix(completion): complete commands after pipe and other separators#1159
Open
Fanteria wants to merge 3 commits into
Open
fix(completion): complete commands after pipe and other separators#1159Fanteria wants to merge 3 commits into
Fanteria wants to merge 3 commits into
Conversation
Tokens that follow |, ||, &&, ;, or & are in command position and should complete from $PATH.
Assisted-by: Claude Sonnet 4.6 (claude.ai/code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
|,||,&&,;, or&as command position inConfig::get_completionsandget_completions_using_basic_lookup, so they complete from$PATH(commands, builtins, functions, aliases) instead of$PWDfiles.cat /dev/null | ec<TAB>would offer file matches (e.g.echoing_file) rather thanecho.|and&&, asserting that the builtin appears and a same-prefix file in$PWDdoes not.Known limitations
grep ec<TAB>: bash performs no completion (grep's first argument is a pattern with no completion spec), while brush falls back to$PATHcompletion.Validation
cargo test -p brush-shell --test brush-completion-tests native_complete_command_after_pipecargo test -p brush-shell --test brush-completion-tests native_complete_command_after_and_operatorcargo clippy -p brush-core --all-targetscargo +nightly fmt -- $(git diff --name-only HEAD -- '*.rs')Manual verification
cargo build --bin brush.echoing_file, launch./target/debug/brush.cat /dev/null | ecand press<TAB>, confirm it completes toechoandecpg.true && ecand press<TAB>, confirm the same behavior.ecat the start of a line and press<TAB>— confirmechoandecpgstill complete.