Skip to content

Add TOML formatting checks#1121

Open
xtqqczze wants to merge 3 commits into
reubeno:mainfrom
xtqqczze:tombi
Open

Add TOML formatting checks#1121
xtqqczze wants to merge 3 commits into
reubeno:mainfrom
xtqqczze:tombi

Conversation

@xtqqczze

@xtqqczze xtqqczze commented May 3, 2026

Copy link
Copy Markdown
Contributor
  • Sort keys in TOML files based on JSON Schema metadata
  • Alphabetize various lists
  • Add Tombi tool to enforce format in CI

Comment thread .github/workflows/ci.yaml Fixed
Comment thread .github/workflows/ci.yaml Fixed
@github-actions

github-actions Bot commented May 4, 2026

Copy link
Copy Markdown

Performance Benchmark Report

Benchmark name Baseline (μs) Test/PR (μs) Delta (μs) Delta %
clone_shell_object 18.25 μs 18.12 μs -0.14 μs ⚪ Unchanged
eval_arithmetic 0.13 μs 0.13 μs 0.00 μs ⚪ Unchanged
expand_one_string 1.59 μs 1.61 μs 0.02 μs ⚪ Unchanged
for_loop 28.11 μs 28.23 μs 0.12 μs ⚪ Unchanged
full_peg_complex 55.49 μs 55.97 μs 0.48 μs ⚪ Unchanged
full_peg_for_loop 6.36 μs 6.50 μs 0.14 μs 🟠 +2.25%
full_peg_nested_expansions 16.27 μs 16.48 μs 0.21 μs ⚪ Unchanged
full_peg_pipeline 4.22 μs 4.29 μs 0.07 μs 🟠 +1.64%
full_peg_simple 1.74 μs 1.79 μs 0.05 μs 🟠 +3.17%
function_call 3.54 μs 3.54 μs 0.01 μs ⚪ Unchanged
instantiate_shell 53.24 μs 53.09 μs -0.14 μs ⚪ Unchanged
instantiate_shell_with_init_scripts 25841.25 μs 25240.77 μs -600.47 μs ⚪ Unchanged
parse_peg_bash_completion 2243.59 μs 2228.53 μs -15.05 μs ⚪ Unchanged
parse_peg_complex 19.26 μs 19.25 μs -0.00 μs ⚪ Unchanged
parse_peg_for_loop 1.93 μs 1.93 μs 0.01 μs ⚪ Unchanged
parse_peg_pipeline 2.05 μs 2.05 μs -0.00 μs ⚪ Unchanged
parse_peg_simple 1.06 μs 1.11 μs 0.05 μs 🟠 +4.41%
run_echo_builtin_command 13.43 μs 13.37 μs -0.06 μs ⚪ Unchanged
tokenize_sample_script 3.52 μs 3.94 μs 0.42 μs 🟠 +11.89%

Code Coverage Report: Only Changed Files listed

Package Base Coverage New Coverage Difference
Overall Coverage 🟢 75.2% 🟢 75.2% ⚪ 0%

Minimum allowed coverage is 70%, this run produced 75.2%

@xtqqczze xtqqczze marked this pull request as ready for review May 4, 2026 00:36
@reubeno

reubeno commented May 5, 2026

Copy link
Copy Markdown
Owner

Thanks for the contribution, @xtqqczze.

What's the main problem you're trying to solve with these changes? These changes are quite wide-sweeping in what they touch.

@xtqqczze xtqqczze marked this pull request as draft May 8, 2026 20:47
@xtqqczze xtqqczze marked this pull request as ready for review May 8, 2026 20:54
@xtqqczze

xtqqczze commented May 8, 2026

Copy link
Copy Markdown
Contributor Author

@reubeno I've removed some stray formatting changes, and updated the PR description to clarify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants