Case in command support#1053
Open
lu-zero wants to merge 3 commits into
Open
Conversation
Add case_statement rule to PEG word parser to correctly parse case statements inside command substitutions. This is a temporary fix until the PEG parser is replaced by winnow for word expansion. Adds test case for case statement inside command substitution.
Track case statement state while tokenizing nested constructs to prevent incorrectly treating ')' in case patterns as the end of command substitution. Fixes parsing of constructs like: echo $(case a in a) echo ok ;; esac)
Performance Benchmark Report
Code Coverage Report: Only Changed Files listed
Minimum allowed coverage is Test Summary: bash-completion test suite
|
7b07c35 to
19aabdc
Compare
Contributor
Author
|
sigh, probably would be easier to get it sorted once we use only the winnow parser. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1052