fix(server): point crawl errors at the crashing source - #903
Merged
Conversation
Signed-off-by: dvd233 <111864431+dvd233@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
reticle_verifycrawl kept the clicked control's source on every anomaly, even when a console or uncaught error carried a more specific location for the code that actually failed. A navigation link could therefore reproduce a destination render crash while the report confidently pointed at the sidebar.This change keeps the clicked control in
ref/desc, but resolves console-faultsourcein this order:source+line;Dependency frames are skipped, browser/dev-server URLs are normalized to file-shaped paths, and unrelated colon-separated message text is not treated as a stack frame.
Closes #890
How it was verified
packages/server/src/crawl/**: 6 files, 63 tests passed.packages/server/src/dispatch-attribution.test.ts+packages/server/src/events/event-filters.test.ts: 32 tests passed.git diff --check, dependency-boundary guard, and lossy-transform guard passed.The full
pnpm lint && pnpm typecheck && pnpm test:unitgate was not run locally because this sparse checkout intentionally reused an existing dependency tree rather than installing the monorepo under the current disk-space constraint; CI will run the repository-native full matrix.Gates run
pnpm lint && pnpm typecheck && pnpm test:unit(~2 min — always)pnpm test:e2e(~8 min) — touched the tool surface,packages/core, an observer, or telemetrypnpm gate:install(~15 min) — touchedreticle init,vite-plugin,next, orbabel-pluginpnpm test:e2e:desktop(~3 min) — touchedpackages/electron,packages/tauri, or desktop captureChecklist
git commit -s) — CI's DCO check fails the PR without it. Already pushed?git rebase --signoff origin/main && git push --force-with-leaseany, no free strings (wire strings live in@reticlehq/core), no non-null!console.logor internal tracking codes left in the diffCHANGELOG.mdupdated if this is user-facing (entry under[Unreleased])docs/telemetry.md) and are covered by a test — not security-affecting