fix: update IntegrationModuleEdit DTOs - #121
Merged
Merged
Conversation
What changed and why: updated IntegrationModuleEdit request and response DTOs to match the current POST /api/v5/integration-modules/{code}/edit contract. The endpoint can return info as an array, including an empty [], while the client previously expected a ResponseInfo object and failed during json.Unmarshal.
Added custom UnmarshalJSON handling for IntegrationModuleEditResponse and ResponseInfo. The legacy object format still fills Info, array-form info is preserved in InfoRaw/InfoList, and an empty [] is treated as missing additional information. Request DTOs now also support the newer documented shapes: object deliveryDataFieldList[].choices via ChoiceList/DeliveryDataFieldChoice and translated embedJs.pages[].pageHelpLink via PageHelpLinks/ConfigurationTranslation.
Backward compatibility: existing public fields Info, AdditionalCode.UserID, DeliveryDataField.Choices, and EmbedJSPage.PageHelpLink are preserved. During marshaling, new fields take precedence when set, but the old format is still used when they are empty. During unmarshaling, newer formats also populate legacy fields where possible: ChoiceList also fills Choices, numeric AdditionalCode userId fills UserID as a string, and translated pageHelpLink fills PageHelpLink with the first available translation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why: updated IntegrationModuleEdit request and response DTOs to match the current POST /api/v5/integration-modules/{code}/edit contract. The endpoint can return info as an array, including an empty [], while the client previously expected a ResponseInfo object and failed during json.Unmarshal.
Added custom UnmarshalJSON handling for IntegrationModuleEditResponse and ResponseInfo. The legacy object format still fills Info, array-form info is preserved in InfoRaw/InfoList, and an empty [] is treated as missing additional information. Request DTOs now also support the newer documented shapes: object deliveryDataFieldList[].choices via ChoiceList/DeliveryDataFieldChoice and translated embedJs.pages[].pageHelpLink via PageHelpLinks/ConfigurationTranslation.
Backward compatibility: existing public fields Info, AdditionalCode.UserID, DeliveryDataField.Choices, and EmbedJSPage.PageHelpLink are preserved. During marshaling, new fields take precedence when set, but the old format is still used when they are empty. During unmarshaling, newer formats also populate legacy fields where possible: ChoiceList also fills Choices, numeric AdditionalCode userId fills UserID as a string, and translated pageHelpLink fills PageHelpLink with the first available translation.