Skip to content

Replace deprecated release action with GH release action - #417

Merged
rspwarnaar merged 2 commits into
mainfrom
Patch-release-workflow
Aug 5, 2026
Merged

Replace deprecated release action with GH release action#417
rspwarnaar merged 2 commits into
mainfrom
Patch-release-workflow

Conversation

@rspwarnaar

@rspwarnaar rspwarnaar commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

📋 Pull Request Template for ReSurfEMG

Summary

Replaced MarvinPinto Github release workflow with Github's native workflow.

Related Issues

N/A

Changes Introduced

List the major changes made in this PR:

  • Changed Github release workflow

Motivation and Context

The previously used release workflow is deprecated.
See: https://github.com/marvinpinto/action-automatic-releases

I expect Github's own workflow to be a sustainable choice.

Testing

N/A

Checklist

  • I have read the contributing guidelines
  • My code follows the project's coding style
  • I have added tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • All existing and new tests pass

Additional Notes

Any other context or information reviewers should know?

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The workflow still uses the old action’s repo_token input (and an apparently incorrect secret name), which is not supported by softprops/action-gh-release and risks breaking or confusing releases.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.

Pull request overview

This PR updates the tag-triggered release workflow to replace the deprecated marvinpinto/action-automatic-releases action with softprops/action-gh-release, aligning the project’s release automation with a maintained GitHub Releases action.

Changes:

  • Swapped the release-publishing action from marvinpinto/action-automatic-releases to softprops/action-gh-release.
  • Kept the existing artifact file list used for release attachments.
File summaries
File Description
.github/workflows/on-tag.yml Replaces the deprecated release action with softprops/action-gh-release for publishing GitHub Releases on tags.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Lite

We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.

Comment thread .github/workflows/on-tag.yml
@codecov

codecov Bot commented Aug 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@ReSurfEMG
ReSurfEMG self-requested a review August 5, 2026 17:37
@rspwarnaar
rspwarnaar merged commit 6b6642e into main Aug 5, 2026
14 checks passed
@rspwarnaar
rspwarnaar deleted the Patch-release-workflow branch August 5, 2026 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants