Skip to content

Restructured info/error messages in config - #415

Merged
rspwarnaar merged 1 commit into
mainfrom
bug/config_location
Aug 4, 2026
Merged

Restructured info/error messages in config#415
rspwarnaar merged 1 commit into
mainfrom
bug/config_location

Conversation

@rspwarnaar

@rspwarnaar rspwarnaar commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

Summary

Restructure error/info messages thrown by config.load()

Related Issues

Fix #414

Changes Introduced

List the major changes made in this PR:

  • When a config file is found, no feedback is given about unsuccessful locations (e.g., WORKDIR/config.json and REPO_ROOT/config.json)
  • Warnings are only provided when none of the options provided a valid config file

Motivation and Context

config.load() returned an INFO message that seemed an error, whereas no real error occurred. With this change, such info will not be returned unless no config file could be identified.

Testing

Describe how you tested your changes. Include:

  • Manual testing steps in config notebook

Checklist

  • I have read the contributing guidelines
  • My code follows the project's coding style
  • I have added tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • All existing and new tests pass

@rspwarnaar rspwarnaar assigned ChiaraM96 and unassigned ChiaraM96 Jul 31, 2026
@rspwarnaar
rspwarnaar requested a review from ChiaraM96 July 31, 2026 18:25
@codecov

codecov Bot commented Jul 31, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
resurfemg/data_connector/config.py 90.90% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@rspwarnaar
rspwarnaar merged commit 0c14799 into main Aug 4, 2026
14 checks passed
@rspwarnaar
rspwarnaar deleted the bug/config_location branch August 4, 2026 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Config still relies on config_example.json

2 participants