Add integrated equation of motion to ReSurfEMG - #413
Merged
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
rspwarnaar
marked this pull request as ready for review
July 31, 2026 16:12
ChiaraM96
reviewed
Aug 3, 2026
ChiaraM96
reviewed
Aug 3, 2026
ChiaraM96
reviewed
Aug 4, 2026
ChiaraM96
reviewed
Aug 4, 2026
ChiaraM96
reviewed
Aug 4, 2026
ChiaraM96
reviewed
Aug 4, 2026
ChiaraM96
reviewed
Aug 4, 2026
ChiaraM96
reviewed
Aug 4, 2026
ChiaraM96
reviewed
Aug 4, 2026
ChiaraM96
reviewed
Aug 4, 2026
ChiaraM96
reviewed
Aug 4, 2026
ChiaraM96
reviewed
Aug 4, 2026
ChiaraM96
reviewed
Aug 4, 2026
ChiaraM96
reviewed
Aug 4, 2026
ChiaraM96
reviewed
Aug 4, 2026
ChiaraM96
reviewed
Aug 4, 2026
ChiaraM96
reviewed
Aug 4, 2026
ChiaraM96
reviewed
Aug 4, 2026
ChiaraM96
reviewed
Aug 4, 2026
ChiaraM96
left a comment
There was a problem hiding this comment.
I finished going over the changes and I flagged down a few small bugs to address before merging - while they didn't seem to affect the results with the current synthetic data, they may become an issue with real data.
Other than that, it all looks nice and clean!
- Created `modelling` subpackage with `tau_estimation` and `integrated_equation_of_motion` submodules. - Added `pneumatic` module in the `preprocessing` package for processing pneumatic data.
…, and ventilation
…or zero crossing indices
… of motion modules
…pdate test cases for tolerance checks
Add UHN affiliation for Rob. Add Stijn
…and filter out NaNs before returning
Collaborator
Author
|
@ChiaraM96 Thanks Chiara. That was really helpful. Could you checkout the new changes? |
ChiaraM96
self-requested a review
August 5, 2026 07:08
ChiaraM96
approved these changes
Aug 5, 2026
ChiaraM96
left a comment
There was a problem hiding this comment.
Everything looks clean and merge-ready!
Added details for release 1.1.1, including new features, updates, and maintenance tasks.
3 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add the integrated equation of motion, as described by Graßhoff 2023 to ReSurfEMG
Related Issues
N/A
Changes Introduced
List the major changes made in this PR:
Motivation and Context
Methods accompany a research paper and increase the robustness of EMG-based assessment of respiratory effort
Testing
Describe how you tested your changes. Include:
Checklist
Additional Notes
Any other context or information reviewers should know?