Skip to content

fix(template): stop top comment leaking + render the hero image#26

Merged
WomB0ComB0 merged 1 commit into
mainfrom
fix/readme-template-comment-and-hero
Jun 13, 2026
Merged

fix(template): stop top comment leaking + render the hero image#26
WomB0ComB0 merged 1 commit into
mainfrom
fix/readme-template-comment-and-hero

Conversation

@WomB0ComB0

Copy link
Copy Markdown
Member

Summary

Fixes two rendering bugs visible when README.template.md is viewed raw on GitHub (from the post-merge screenshots).

1. Top comment leaked as visible text

Line 8 read 4. Delete all HTML comments (<!-- ... -->) before publishing. The literal --> closed the opening <!-- comment early, so the usage notes (lines 8–17) and a stray --> rendered as body text at the top of the page. Reworded to Delete all HTML comment blocks before publishing — no nested terminator, comment stays hidden. Audited the rest of the file: the large automation comment (375–583) is intact; no other nested -->.

2. Broken hero image

The hero <img> pointed at assets/logo.png, which doesn't exist in the repo, so it rendered as a broken-image icon. Now defaults to the ResQ org banner via an absolute raw URL (verified HTTP 200) so it renders both in the raw template and in freshly-copied repos; consumers swap it for their own assets/ logo/banner.

Not changed (expected behavior)

The red "not found" badges and blank Repobeats/contributor images in the screenshots are inherent to an unfilled template — they reference {{NPM_PACKAGE}}, {{REPO}}, {{REPOBEATS_HASH}}, etc. They resolve once the template is copied and placeholders are filled. (Happy to add a visible "this is a template" notice or convert the example badges to a commented snippet if you'd rather the raw file render pristine — say the word.)

Test plan

  • Comment audit: only the intended closer on line 17 remains before the hero; automation comment balanced
  • Banner absolute URL returns HTTP 200
  • repo-standards / required-gate green on this PR
  • Visual recheck of the rendered raw template (top no longer leaks; banner shows)

Two rendering bugs visible in the raw template on GitHub:

- The header comment closed early. Line 8 read "Delete all HTML comments
  (<!-- ... -->) before publishing" — the literal `-->` terminated the
  opening `<!--` comment, so lines 8–17 (usage notes + the `-->`) rendered
  as visible text. Reworded to "Delete all HTML comment blocks before
  publishing" so the comment stays a comment.
- The hero `<img>` pointed at assets/logo.png, which doesn't exist, so it
  rendered as a broken image. Default to the ResQ org banner via an absolute
  raw URL (HTTP 200) so it renders in the raw template and in fresh repos;
  consumers swap it for their own asset.

Remaining placeholder-driven artifacts (red "not found" badges, blank
Repobeats/contrib images) are expected for an unfilled template and resolve
once {{PLACEHOLDER}} values are filled in.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 13, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@WomB0ComB0, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 25 minutes and 23 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more credits in the billing tab to continue.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4c89b22a-7265-4948-b722-3a641544cb17

📥 Commits

Reviewing files that changed from the base of the PR and between 0509bf3 and 6a6530a.

📒 Files selected for processing (1)
  • README.template.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/readme-template-comment-and-hero

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the README.template.md file by clarifying the instruction to delete HTML comment blocks and replacing the local placeholder logo with an absolute URL pointing to the ResQ organization banner. There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@WomB0ComB0 WomB0ComB0 merged commit 3edabd2 into main Jun 13, 2026
8 checks passed
@WomB0ComB0 WomB0ComB0 deleted the fix/readme-template-comment-and-hero branch June 13, 2026 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant