Skip to content

fix(editor): support heading node placeholders #3714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Iiviavs wants to merge 1 commit into
base: canary
Choose a base branch
from
+8 −4
Open

fix(editor): support heading node placeholders #3714

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions packages/editor/src/email-editor/email-editor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,9 +150,6 @@ export const EmailEditor = forwardRef<EmailEditorRef, EmailEditorProps>(
placeholder:
placeholder ??
(({ node }) => {
// TODO: this heading placeholder is not working,
// in part because styles are only targetting paragraphs,
// but in part because of the way the content is rendered
if (node.type.name === 'heading') {
return `Heading ${node.attrs.level}`;
}
Expand Down
9 changes: 8 additions & 1 deletion packages/editor/src/ui/themes/default.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,7 +397,14 @@
color: var(--re-text);
}

.tiptap p.is-empty::before {
.tiptap p.is-empty::before,
.tiptap h1.is-empty::before,
.tiptap h2.is-empty::before,
.tiptap h3.is-empty::before,
.tiptap h4.is-empty::before,
.tiptap h5.is-empty::before,
.tiptap h6.is-empty::before,
.tiptap div.is-empty[data-placeholder]::before {
opacity: 0.3;
float: left;
content: attr(data-placeholder);
Expand Down