Skip to content

refactor: establish UIEvents folder feature - #332

Merged
jderochervlk merged 1 commit into
codex/option5-observers-folderfrom
codex/option5-ui-events-folder
Aug 7, 2026
Merged

refactor: establish UIEvents folder feature#332
jderochervlk merged 1 commit into
codex/option5-observers-folderfrom
codex/option5-ui-events-folder

Conversation

@jderochervlk

@jderochervlk jderochervlk commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Tracking issue: #342

Stack context

Part 22 of the Option 5 folder-feature stack.

Review this PR as the incremental diff against #331.

Summary

  • rename src/UIEvents to the target src/ui-events folder
  • switch the folder to the unqualified internal UIEvents feature
  • add the supported WebAPI.UIEvents -> WebAPI.DOMNodes + WebAPI.File + UIEvents feature
  • preserve all existing flat UI event module paths and binding signatures

Temporary state

  • the legacy broad WebAPI.DOM source entry remains until its remaining interfaces have been assigned
  • final feature-graph guardrails and cleanup remain deferred until the stack is complete

Review focus

  • the lowercase folder/internal feature transition
  • the DOMNodes/File dependency closure
  • preservation of flat public modules

Verification

  • node_modules/.bin/rescript clean
  • node_modules/.bin/rescript build --prod --features DOM,Event,DOMPlatform,Animation,CSSOM,Geometry,DOMNodes,File,UIEvents
  • npm run build
  • npm test
  • npm run format:check
  • git diff --check

Copy link
Copy Markdown
Collaborator Author

@codex

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9e7487d1ad

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread rescript.json
@jderochervlk
jderochervlk force-pushed the codex/option5-ui-events-folder branch 3 times, most recently from 8f2b70b to 3f4a3f7 Compare August 5, 2026 12:31
@jderochervlk
jderochervlk force-pushed the codex/option5-ui-events-folder branch from 3f4a3f7 to 90f3b4f Compare August 5, 2026 12:34
@jderochervlk
jderochervlk force-pushed the codex/option5-ui-events-folder branch from 90f3b4f to 6f22809 Compare August 5, 2026 13:40
@jderochervlk
jderochervlk force-pushed the codex/option5-ui-events-folder branch from 6f22809 to e843c30 Compare August 5, 2026 13:57
@jderochervlk
jderochervlk force-pushed the codex/option5-ui-events-folder branch 2 times, most recently from 02ed564 to e2825ef Compare August 5, 2026 14:30
@jderochervlk
jderochervlk force-pushed the codex/option5-ui-events-folder branch from e2825ef to 93c4403 Compare August 5, 2026 14:50
@jderochervlk
jderochervlk force-pushed the codex/option5-ui-events-folder branch 2 times, most recently from 33ead6f to ab78941 Compare August 5, 2026 15:45
@jderochervlk
jderochervlk force-pushed the codex/option5-ui-events-folder branch from ab78941 to 7a1aa10 Compare August 5, 2026 17:40
@jderochervlk
jderochervlk requested review from brnrdog and tsnobip August 6, 2026 14:45
@jderochervlk
jderochervlk force-pushed the codex/option5-ui-events-folder branch from 7a1aa10 to 928a9c7 Compare August 6, 2026 14:52
@jderochervlk
jderochervlk force-pushed the codex/option5-ui-events-folder branch from 845b875 to 98dde1f Compare August 7, 2026 13:45
@jderochervlk
jderochervlk force-pushed the codex/option5-ui-events-folder branch from 98dde1f to 99c081c Compare August 7, 2026 13:45
@jderochervlk
jderochervlk force-pushed the codex/option5-ui-events-folder branch from 99c081c to 2304483 Compare August 7, 2026 13:50
@jderochervlk
jderochervlk force-pushed the codex/option5-ui-events-folder branch from 2304483 to 2eb1186 Compare August 7, 2026 13:54
@jderochervlk
jderochervlk force-pushed the codex/option5-ui-events-folder branch from 2eb1186 to 4242fb7 Compare August 7, 2026 13:56
@jderochervlk
jderochervlk force-pushed the codex/option5-ui-events-folder branch from 4242fb7 to e6c3833 Compare August 7, 2026 13:57
@jderochervlk
jderochervlk force-pushed the codex/option5-ui-events-folder branch from e6c3833 to b06b479 Compare August 7, 2026 13:58
@jderochervlk
jderochervlk force-pushed the codex/option5-ui-events-folder branch from b06b479 to 9627a20 Compare August 7, 2026 14:00
@jderochervlk
jderochervlk force-pushed the codex/option5-ui-events-folder branch from 9627a20 to 7957f43 Compare August 7, 2026 14:00
@jderochervlk
jderochervlk force-pushed the codex/option5-ui-events-folder branch from 7957f43 to d92f777 Compare August 7, 2026 14:01
@jderochervlk
jderochervlk force-pushed the codex/option5-ui-events-folder branch from d92f777 to fae334b Compare August 7, 2026 14:03
@jderochervlk
jderochervlk force-pushed the codex/option5-ui-events-folder branch from fae334b to 89b90f0 Compare August 7, 2026 14:04
@jderochervlk
jderochervlk force-pushed the codex/option5-ui-events-folder branch from 89b90f0 to bb29906 Compare August 7, 2026 14:04
@jderochervlk
jderochervlk force-pushed the codex/option5-ui-events-folder branch from bb29906 to 5d90a48 Compare August 7, 2026 14:07
@jderochervlk
jderochervlk force-pushed the codex/option5-ui-events-folder branch from 5d90a48 to 98e8c28 Compare August 7, 2026 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants