Revert lru_cache for request lock to avoid attempting to bind to multiple event loops - #407
Merged
Conversation
JWCook
changed the title
JWCook
marked this pull request as ready for review
August 5, 2026 18:46
alessio-locatelli
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up from #406
So far I've only seen the original
RuntimeErroron python 3.14, but that is likely coincidence (nothing relevant to async locks changed in 3.14).This change keeps the behavior of A) using one lock per cache key, and B) not keeping an unbounded amount of lock objects indefinitely (using
weakref).