Skip to content

fix(ci): stop publishing to PyPI through a reusable workflow #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jimisola merged 4 commits into from
Aug 23, 2026
Merged

fix(ci): stop publishing to PyPI through a reusable workflow #91

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c52e3fd
fix(ci): stop publishing to PyPI through a reusable workflow
jimisola Aug 23, 2026
c8cae77
fix(ci): drop Test PyPI entirely rather than fix its trusted publisher
jimisola Aug 23, 2026
3c22f64
fix(ci): pin the publish-to-pypi action reference to a commit
jimisola Aug 23, 2026
8a7a763
Merge branch 'main' into fix/pypi-trusted-publishing-composite-action
jimisola Aug 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions .github/workflows/publish-dev-to-testpypi.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,13 @@

publish-to-test-pypi:
needs: build
uses: reqstool/.github/.github/workflows/python-publish-to-pypi.yml@main
runs-on: ubuntu-latest
environment:
name: test
url: https://test.pypi.org
permissions:
id-token: write
with:
target: testpypi
steps:
- uses: reqstool/.github/.github/actions/publish-to-pypi@main
Comment thread
github-advanced-security[bot] marked this conversation as resolved.
Fixed
Comment thread
github-advanced-security[bot] marked this conversation as resolved.
Fixed
with:
target: testpypi
26 changes: 18 additions & 8 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,25 +97,35 @@

publish-to-testpypi:
needs: [prepare, assets]
uses: reqstool/.github/.github/workflows/python-publish-to-pypi.yml@main
runs-on: ubuntu-latest
environment:
name: test
url: https://test.pypi.org
permissions:
id-token: write
with:
target: testpypi
artifact: dist-tagged
steps:
- uses: reqstool/.github/.github/actions/publish-to-pypi@main
Comment thread
github-advanced-security[bot] marked this conversation as resolved.
Fixed
Comment thread
github-advanced-security[bot] marked this conversation as resolved.
Fixed
with:
target: testpypi
artifact: dist-tagged

# PyPI is the only step here that cannot be undone: a version can be yanked but
# never replaced. A release candidate stops at Test PyPI -- pip needs --pre to
# see a prerelease anyway.
publish-to-pypi:
needs: [prepare, publish-to-testpypi]
if: ${{ needs.prepare.outputs.prerelease != 'true' }}
uses: reqstool/.github/.github/workflows/python-publish-to-pypi.yml@main
runs-on: ubuntu-latest
environment:
name: stable
url: https://pypi.org
permissions:
id-token: write
with:
target: pypi
artifact: dist-tagged
steps:
- uses: reqstool/.github/.github/actions/publish-to-pypi@main
Comment thread
github-advanced-security[bot] marked this conversation as resolved.
Fixed
Comment thread
github-advanced-security[bot] marked this conversation as resolved.
Fixed
Comment thread
github-advanced-security[bot] marked this conversation as resolved.
Fixed
with:
target: pypi
artifact: dist-tagged

# Last, deliberately. Everything above can fail, and until this runs nothing
# resolving "the latest release" can see what was built -- the release is still
Expand Down