fix: SVC filters not applied to all imports when MICROSERVICE variant is present - #232
Merged
Conversation
… present When traversing the parsing graph for SVC filter processing, a break statement caused the loop to exit on the first MICROSERVICE import URN, silently skipping all subsequent import URNs regardless of their variant. Change break to continue so MICROSERVICE URNs are individually skipped and processing continues for all remaining imports, consistent with how __process_req_filters_per_urn already handles this case. Fixes #231, refs #222.
jimisola
enabled auto-merge (squash)
March 1, 2026 09:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
break→continuein__process_svc_filters_per_urn, making it consistent with the already-correct__process_req_filters_per_urnFixes #231, refs #222.
Test plan
94 passed)