composer: switch to upstream adodb/adodb-php from stale reportico/adodb-php fork - #59
Open
pixilla wants to merge 1 commit into
Open
Conversation
…db-php fork The current `reportico/adodb-php: ^8.1` dependency is a long-stale snapshot of an older ADOdb release. It has not received any of the upstream security or PHP 8.x compatibility fixes that have shipped since. Switching to the actively maintained upstream package brings in: - Multiple security advisories fixed in 5.22.10 / 5.22.11 (PKSA-rfc1-gnmf-7kkz, PKSA-jm5q-b4t5-4pm4, etc.); previous ADOdb versions are flagged by composer audit. - PHP 8.5 source compatibility — the `(integer)` cast deprecations that originally required custom patches against the reportico fork were already addressed upstream (see ADOdb commits replacing `(integer)` with `(int)` in 5.22.10 / 5.22.11). - PDO/oci8/postgres driver bug fixes accumulated since the fork. No source changes are required in Reportico itself: the existing code uses the standard `ADODB_*` global-namespace classes/constants and the `ADODB_DIR` constant, all of which are identical between the two packages. Tested on PHP 8.5.1 (MacPorts) with adodb/adodb-php v5.22.11 against a PostgreSQL backend: report run, criteria selection, HTML output and TCPDF PDF generation all behave identically to the previous build. Co-authored-by: Cursor <cursoragent@cursor.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the long-stale
reportico/adodb-php: ^8.1Composer dependency with the actively maintained upstream packageadodb/adodb-php: ^5.22.11.The
reportico/adodb-phppackage is a snapshot of an older ADOdb release and has not received any of the upstream security or PHP 8.x compatibility fixes that have shipped since.Why
Switching to upstream brings in:
composer auditflags the previous package because of advisories patched in 5.22.10/5.22.11 (PKSA-rfc1-gnmf-7kkz,PKSA-jm5q-b4t5-4pm4).(integer)cast deprecations that previously required a custom patch against the reportico fork were already addressed upstream (ADOdb 5.22.10/5.22.11 replaced(integer)with(int)throughout).What changes
A single line in
composer.json: