Fix mapping exception on empty PartTypeId during bulk part creation - #522
Open
Sylensky wants to merge 1 commit into
Open
Fix mapping exception on empty PartTypeId during bulk part creation#522Sylensky wants to merge 1 commit into
Sylensky wants to merge 1 commit into
Conversation
AutoMapper's default string->long conversion threw a FormatException when a part's PartTypeId was an empty string, crashing bulk part creation. Added a safe TryParse-based mapping that defaults to 0, letting the existing fallback logic resolve the part type as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AutoMapper's default string->long conversion threw a FormatException when a part's PartTypeId was an empty string, crashing bulk part creation. Added a safe TryParse-based mapping that defaults to 0, letting the existing fallback logic resolve the part type as before.