Make Attestation fields nullable to match TU API spec; add CI#1
Merged
Conversation
- Add .github/workflows/ci.yml running phpunit --testsuite unit on PHP 8.4 for every push and PR against master - Switch coding-standard-php repository URL from SSH to HTTPS now that the package is public, so composer install works in CI without auth
Triggered only by workflow_dispatch so PR runs never burn TransUnion sandbox quota and secrets aren't exposed to fork PRs. Required repository secrets: TU_SHAREABLE_URL, TU_SHAREABLE_CLIENT_ID, TU_SHAREABLE_API_KEY_ONE, TU_SHAREABLE_API_KEY_TWO.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Attestation.name,Attestation.legalText, andAttestation.additionalInformationare all nullable. Our DTO had them as non-nullablestring(withAssert\NotBlankon name/legalText), so any attestation with a null/missing field from TU would throwTypeErrorduring deserialization.AttestationGroup::fromArraynow tolerates missing or nullattestationskeys, andAttestationGroup::toArrayno longer iterates over null arrays..github/workflows/ci.ymlrunsphpunit --testsuite uniton every push/PR against master. Switches thecoding-standard-phprepository URL to HTTPS so the workflow can install dev deps without SSH auth (the package is now public).Test plan
vendor/bin/phpunit --testsuite unit— 66 tests pass (10 new acrossAttestationTest+ newAttestationGroupTest)attestationskey infromArray, nullattestationsvalue, emptytoArray, false-affirmative responsesRelated
hotfix/attestation-affirmative-requiredbranch which fixes the manager-facing UI that hardcodedtruefor every attestation response