Replace FilterStrategy::Strict with strict: bool flag#6
Merged
Conversation
Strict coverage enforcement is orthogonal to the matching strategy (FirstMatch/AnyMatch). Making it a third FilterStrategy case coupled two unrelated concerns and prevented FirstMatch + deny-uncovered. Now strict is a bool on #[MultiTenancy], usable alongside any strategy. BREAKING CHANGE: FilterStrategy::Strict removed. Replace `strategy: FilterStrategy::Strict` with `strict: true`.
Moves strict mode into its own section rather than nesting it as a sibling example under FilterStrategy usage. Ambient Context Providers is now a subsection of Strict Mode, where it's contextually relevant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FilterStrategycase prevented legitimate combinations likeFirstMatch + deny-uncoveredstrictis now a bool on#[MultiTenancy], usable alongside anyFilterStrategystrict: truevsstrategy: FilterStrategy::StrictBefore
#[MultiTenancy( strategy: FilterStrategy::Strict, filters: [...] )]After
#[MultiTenancy( strict: true, filters: [...] )]Breaking change
FilterStrategy::Strictremoved. Anywhere you hadstrategy: FilterStrategy::Strict, replace withstrict: true(default strategy isAnyMatch, which matches the old Strict behavior).Test plan