Add AmbientContextProviderInterface for Strict strategy#5
Merged
Conversation
Ambient context providers (e.g., "any role active", "user logged in") represent always-on environmental state, not discrete access levels. Strict now skips them during coverage checks, preventing universal denial from always-active meta-contexts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AmbientContextProviderInterface— a marker interface for context providers that represent always-on environmental state (e.g., "any role active", "user logged in")Context
FilterStrategy::Strictdenies access when an active context isn't covered by any filter. But meta-contexts likerole(always true when authenticated) anduser(always true when a user is on the stack) are never listed in filtercontext:arrays — they'd cause every query to be denied, including managers.Test plan
testStrictAmbientContextIsSkipped— ambient providers active but skipped, no denialtestStrictAmbientContextDoesNotMaskUncovered— ambient skipped but non-ambient uncovered context still triggers denial