Add Strict FilterStrategy#4
Merged
Merged
Conversation
Strict works like AnyMatch for processing filters, but after the filter loop, any active ContextProvider whose identifier is not covered by a filter's context array causes 1 = 0 to be appended (denying all results). This eliminates the need to explicitly deny every uncovered context.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Strictcase to theFilterStrategyenum — a deny-by-default strategyAnyMatch, but after the filter loop, if any activeContextProvideris not covered by any filter'scontext:array, appends1 = 0(denying all results)ignore: truecounts as "covered" — the context is acknowledged, just without extra conditionsKey behaviors
context: []) still apply to all contexts1 = 0is ever appended (early return on first uncovered context)ContextProvideris active at all, no denial occursTest plan
ConditionResolverTest: covered context, ignored-as-covered, uncovered denial, no-active-context, multiple-active-one-uncoveredFilterStrategyTestfor 3 enum cases