feat: add ConditionResolver, test suite, and CI#3
Merged
Conversation
Extract SQL generation logic from Filter (Doctrine SQLFilter) into a standalone ConditionResolver class that can resolve multi-tenancy conditions for any entity class without requiring DQL or ClassMetadata. This enables raw SQL repository queries to reuse the same tenant-scoping logic defined in #[MultiTenancy] attributes. - Add ConditionResolver with resolve(entityClass, tableAlias) method - Refactor Filter to delegate to ConditionResolver - Add comprehensive PHPUnit 11 test suite (40 tests, 60 assertions) - Add GitHub Actions CI workflow (PHP 8.2/8.3/8.4 matrix) - Add Makefile with standard recipes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#[MultiTenancy]entity attributes without requiring Doctrine's DQL/SQLFilter lifecycle. Enables raw SQL repository queries to reuse the same tenant-scoping logic.Filter::addFilterConstraint()now delegates toConditionResolver, keeping the SQLFilter as a thin adapter.ConditionResolver,Filter,Listener, and all attribute classes.make test,make init, etc.)Usage (ConditionResolver)
Test plan
make testpasses locally (40/40 tests, 60 assertions)