Unblock the v0.2.4 release gates - #9
Merged
Merged
Conversation
The AppImage smoke gate has failed on every v0.2.4 RC, so the deb/rpm smoke and the asset attach behind it have not run since v0.2.3. Both carry a regression. The native-package smoke still asserts a 512x512 PNG icon. nfpm stopped shipping one in 1e45e70, which lands the icon bands as SVG masters instead, so the deb smoke would have failed the moment it ran. The attach job reads the desktop artifacts as a flat directory, but upload-artifact roots the artifact at the common ancestor of its path globs and the download arrives split across appimage/ and packages/. Every lookup missed, every architecture was skipped without complaint, and the upload then choked on a directory in its glob -- which is why v0.2.3 carries no AppImage, deb or rpm asset at all and the README's /releases/latest/download links point at nothing. Flatten the download first, and fail loudly rather than silently skipping an architecture.
rengwu
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three release-blocking defects, two of them latent behind the first.
GTK's) closed the single-quoted container script early. RC3 rendered the cockpit at mean brightness 15/255, then exited 127 at that boundary. CI now runsbash -n scripts/*.sh.1e45e70moved the icon bands to SVG masters; the smoke still required/usr/share/icons/hicolor/512x512/apps/chartr.png. This step has not run since v0.2.3, so it would have failed the moment RC4 got past the AppImage gate.upload-artifactroots the artifact at the common ancestor of its path globs, so the download arrives split acrossappimage/andpackages/, not flat. Every lookup missed, every architecture was skipped without complaint, andgh release upload linux-desktop/*then choked on a directory. v0.2.3 carries no AppImage, deb or rpm asset at all and its/releases/latest/download/links point at nothing. The download is now flattened first, and a missing architecture fails loudly.Evidence
screenshot: mean brightness 15/255 across 780 coloursthenexit code 127.WM_CLASS(STRING) = "chartr", "Chartr", which is what the assertion (andStartupWMClass) now expect, so that check should pass once it is reachable.read linux-desktop/appimage: is a directory;gh release view v0.2.3lists no Linux desktop assets.Not verified here
The deb/rpm smoke and the attach job cannot run outside CI (no Docker on this machine). These fixes are read from the artifact layout and the nfpm payload rather than from a green run, so RC4 is still the real test.