chore: fix docs deploy, patch advisories, support Laravel 13 - #167
Merged
Conversation
Deploy Docs has failed on every push to 4.x since better-sqlite3 was bumped to 13.0.3 (#162). docus 5.12.3 declares a `better-sqlite3: 12.x` peer, so `npm ci` died on ERESOLVE and the docs never deployed. Pinned back to ^12.11.1, which is the range docus actually supports. Patched the two open advisories the lockfile carried, via overrides because both come from transitive deps: - esbuild <0.28.1, arbitrary file read via the dev server (dependabot #143) - sharp <0.35.0, inherited libvips CVEs (hoisted copy was 0.34.5) `npm audit --omit=dev` now reports zero vulnerabilities, and `npm ci` plus `npm run generate` both complete locally. Both open issue reports on this package ran Laravel 13, which the dev constraints did not allow. Widened testbench and Pest to accept 11.x/5.x alongside 10.x/4.x, and added a Laravel 13 job to the test matrix. The suite passes on both: 161 tests on L12.67 with Pest 4, and on L13.26 with Pest 5.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three related maintenance items on
4.x.Docs deploy has been failing on every push
Deploy Docshas failed on every push to4.xsince #162 bumpedbetter-sqlite3to 13.0.3, including both fix merges today.docus@5.12.3declares abetter-sqlite3: 12.xpeer, sonpm ciaborts:The docs site has not deployed since. Pinned back to
^12.11.1, the range docus supports. There is no newer docus: 5.12.3 is latest and still declares the same peer, so bumping forward was not an option.Two open advisories in the docs lockfile
Both come from transitive deps, so they are fixed with
overridesrather than direct bumps:<0.28.1, arbitrary file read when running the dev server on Windows (dependabot alert build(deps): bump @nuxt/scripts from 1.3.0 to 1.3.1 in /docs #143). Pulled in by@nuxt/scripts,@nuxt/ui,@unhead/vueandvite; hoisted copy was 0.27.7, now 0.28.2.<0.35.0, inherited libvips CVEs (CVE-2026-33327, -33328, -35590, -35591). Reached throughnuxt-og-image, which declaressharp: ^0.34.0; hoisted copy was 0.34.5, now 0.35.3.npm audit --omit=devwent from 3 high severity vulnerabilities to 0.Laravel 13 was never testable
Both open bug reports on this package (#156, #164) were filed against Laravel 13, which the dev constraints did not allow, so nothing verified the package there. Widened
orchestra/testbenchto^10.11|^11.0and the three Pest packages to^4.0|^5.0, then added a Laravel 13 job to the matrix. The runtimerequireblock is untouched: this only affects what the package can be tested against.Verification
Locally, running exactly what CI runs:
npm ciindocs/succeeds (this is the step that was failing)npm run generatecompletes, 47 routes prerendered, build cleannpm audit --omit=dev: 0 vulnerabilitieslaravel/framework:12.*+testbench:10.*, prefer-stable): resolves L12.67 with Pest 4, 161 tests passtestbench:11.*): resolves L13.26 with Pest 5, 161 tests passvendor/bin/pint --test: passesvendor/bin/phpstan analyse: 7 errors, the same seven places as before this branch (pre-existing)