优化ID判断逻辑,以支持大于32位有限符号整数的情况(BusyBox 32bit) - #151
Open
Gnail89 wants to merge 2 commits into
Open
Conversation
Author
|
使用dnspod获取recordId可能超过int长度,导致脚本中recordId判断条件执行失败,建议将if ! [ "$recordId" -gt 0 ] 2>/dev/null ;then 更新为 if [ "$(echo "$recordId 0" |awk '{print ($1 > $2)}')" -eq 0 ] 2>/dev/null ;then,使用awk命令判断超过长度的recordId。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in v6.1.x
@@ -138,7 +138,7 @@ arDdnsIds() {
domainId=$(arDdnsApi "Domain.Info" "domain=$2")
domainId=$(echo $domainId | sed 's/."id":"([0-9])".*/\1/')
- if ! [ "$domainId" -gt 0 ] 2>/dev/null ;then
+ if [ "$(echo "$domainId 0" |awk '{print ($1 > $2)}')" -eq 0 ] 2>/dev/null ;then
errMsg=$(echo $domainId | sed 's/."message":"([^\"])"./\1/')
echo "arDdnsIds - $errMsg"
return 1
@@ -148,7 +148,7 @@ arDdnsIds() {
recordId=$(arDdnsApi "Record.List" "domain_id=$domainId&sub_domain=$3&record_type=$1")
recordId=$(echo $recordId | sed 's/."id":"([0-9])"./\1/')
- if ! [ "$recordId" -gt 0 ] 2>/dev/null ;then
+ if [ "$(echo "$recordId 0" |awk '{print ($1 > $2)}')" -eq 0 ] 2>/dev/null ;then
errMsg=$(echo $recordId | sed 's/."message":"([^\"])".*/\1/')
echo "arDdnsIds - $errMsg"
return 1