Skip to content

Update results presentation#58

Draft
morganspencerdev wants to merge 3 commits into
redwoodjs:mainfrom
morganspencerdev:results-presentation
Draft

Update results presentation#58
morganspencerdev wants to merge 3 commits into
redwoodjs:mainfrom
morganspencerdev:results-presentation

Conversation

@morganspencerdev

@morganspencerdev morganspencerdev commented Apr 21, 2021

Copy link
Copy Markdown
Contributor

Overview

Puts the Auth Results and Refresh Token Status into modals. This is a PR to start forming ideas from #51

Closes #51

  • Adds Modal component (HeadlessUI Dialog) that can be reused throughout the app
  • Wraps AuthResults and PollCurrentProvider components in Modals
  • Creates a component with both components that can be dropped into each provider

Notes

From @dthyresson here:

@dac09 makes a good point - with the modal hidden, it won't show the status info if there is a problem readily. Unless the button caption informs you of the problem.

The way the Modals are added to the components it has the button included as well so we could perhaps have an indicator on those.

It looks like there might be an error with Firebase in this format. Firebase didn't have the Apollo Provider wrapping it, fixed in latest commit

Screenshots

image

image

@netlify

netlify Bot commented Apr 21, 2021

Copy link
Copy Markdown

Deploy request for redwood-playground-auth accepted.

Accepted with commit 8f6d2a9

https://app.netlify.com/sites/redwood-playground-auth/deploys/60804cad04974800077b25ac

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ideas to refine AuthResults and PollCurrentVersionCell presentation

1 participant