rebase and add codemirror in AuthResults.js w/ theme#47
Conversation
WizardSource
commented
Apr 19, 2021
WizardSource
commented
|
🔨 Explore the source changes: 4915724 |
|
@WizardSource thanks for this! I know we pushed a few other UI changes in but letting @Tobbe have a look as this can def clear up the JSON user metadata for the moment. |
| currentUser: | ||
| <pre style={{ margin: 0 }}>{JSON.stringify(currentUser, null, 2)}</pre> | ||
| </code> | ||
| const authData = (userMetadata, currentUser) => { |
There was a problem hiding this comment.
I'd move this function out of the component. No need to recreate it on every render.
There was a problem hiding this comment.
@Tobbe Thank you, will implement that once I get out of class and look into highlightjs
| return ( | ||
| <div className="w-full text-sm"> | ||
| <p className="mt-2 text-sm text-gray-600 max-w"> Last update {lastUpdate}</p> | ||
| <Codemirror |
There was a problem hiding this comment.
Should we use CodeMirror or highlightjs? Redwoodjs.com uses highlightjs.
We're going to have code samples, and maybe these presentations should use the same package?
There was a problem hiding this comment.
CodeMirror is a code editor. Are we going to be using any of the edit features? If not, I say we use the same here as we do for the code samples
There was a problem hiding this comment.
Ok, if
CodeMirror is a code editor.
then that doesn't seem the best tool.
I think @morganmspencer is working on the Code Samples. Once those are in, we can use the same package here to format the JSON for the User.
There was a problem hiding this comment.
@dthyresson that makes sense, I actually am not familiar w/ highlightjs I'll take a look at it once I'm done with class.
Co-authored-by: Tobbe Lundberg <tobbe@tlundberg.com>
3 participants
