DOC-2210: Document SAP HANA connector (sap_hana input + hana driver)#464
Draft
JakeSCahill wants to merge 1 commit into
Draft
DOC-2210: Document SAP HANA connector (sap_hana input + hana driver)#464JakeSCahill wants to merge 1 commit into
JakeSCahill wants to merge 1 commit into
Conversation
Draft docs for the SAP HANA connector (ENG-1213 / connect#4462, not yet merged): - New modules/components/pages/inputs/sap_hana.adoc: reading modes (bulk, incrementing, timestamp, timestamp+incrementing, query), examples for each mode plus schema_registry_encode auto-registration, metadata, permissions, and a hand-authored configuration-fields table (to be replaced by the generated partial once the connector ships). - nav entry under Connect inputs. - sql_raw: self-managed-only (ifndef::env-cloud) SAP HANA section showing driver: hana and the UPSERT ... WITH PRIMARY KEY syntax. Enterprise, self-managed only (cloud=n). component_type_dropdown is commented out until sap_hana lands in the upstream info.csv, matching the iceberg pattern. Version intentionally omitted (source Version tag is stale; real version unknown until merge).
✅ Deploy Preview for redpanda-connect ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Draft docs for the SAP HANA connector, per DOC-2210 (eng: ENG-1213). Two deliverables:
sap_hanainput — new page documenting all reading modes, per-mode examples,schema_registry_encodeauto-registration, metadata, permissions, and configuration fields.hanadriver forsql_insert/sql_raw— a self-managed-only SAP HANA section onsql_rawcoveringdriver: hanaand the distinctiveUPSERT ... WITH PRIMARY KEYsyntax.The connector is not yet merged (redpanda-data/connect#4462, not on
main). This PR is intentionally a draft:component_type_dropdown::[]is commented out untilsap_hanalands in the upstreaminfo.csv(same pattern as theicebergpage).Version()tag is stale (4.92.0, already shipped without this feature); the real version is unknown until merge.Changes
modules/components/pages/inputs/sap_hana.adoc(new)modules/ROOT/nav.adoc— input nav entrymodules/components/pages/outputs/sql_raw.adoc—ifndef::env-cloud[]SAP HANA section (self-managed only)Verification
hanadriver + DSN, and cloud=n all verified against connect#4462 source (internal/impl/saphana/,internal/impl/sql/conn_fields.go,internal/plugins/info.csv).sql_rawsection renders in the connect build and is suppressed in cloud.Findings for engineering / reviewers (from research)
bulk,incrementing,query,timestamp,timestamp+incrementing), not the 3 in the ticket — docs describe all 5. Worth confirming the ticket/epic should be updated.Version("4.92.0")is stale — needs correcting at merge (see also the pattern of CON-513 for the jira input).info.csvmarkssap_hanacloud=n("not yet certified for cloud"). No cloud-docs follow-up until that changes.hanaalso enables it insql_selectand the sql processors, not just the two named outputs. Likely intended.tlsfield found; presumably DSN-param based — confirm.Once the connector merges and docs regenerate, mark ready for review and swap the hand-authored fields table for the generated partial.