Fix redisAsyncDisconnect to wait for pending replies in pub/sub mode - #1321
Open
sthairno wants to merge 2 commits into
Open
Fix redisAsyncDisconnect to wait for pending replies in pub/sub mode#1321sthairno wants to merge 2 commits into
sthairno wants to merge 2 commits into
Conversation
Verify redisAsyncCommand waits for pending command completion in pubsub mode (redis#1320)
|
Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset. In case there are security findings, they will be communicated to you as a comment inside the PR. Hope you’ll enjoy using Jit. Questions? Comments? Want to learn more? Get in touch with us. |
sthairno
marked this pull request as ready for review
February 22, 2026 18:36
sthairno
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1320
Hello, I fixed an issue when Pub/Sub mode is enabled,
redisAsyncDisconnectcould disconnect before pending reply handling had completed.This change is based on the approach in #1038. If you spot any problems, please let me know.
Thanks!